Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/164 enhance delete to support all metadata types (REST) #1192

Merged
merged 11 commits into from
Jan 29, 2024
Merged

Feature/164 enhance delete to support all metadata types (REST) #1192

merged 11 commits into from
Jan 29, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jan 26, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (via release v7.0.0 #1193)

@JoernBerkefeld JoernBerkefeld added the c/importFile COMPONENT label Jan 26, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone Jan 26, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 26, 2024
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Jan 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

Coverage Report

Commit:f067b06
Base: develop@bc0261e

Type Base This PR
Total Statements Coverage  64.29%  64.57%  (+0.28%)
Total Branches Coverage  67.25%  66.21%  (-1.04%)
Total Functions Coverage  73.52%  74.05%  (+0.53%)
Total Lines Coverage  64.29%  64.57%  (+0.28%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Asset.js  41.43%  48.83%  41.17%  41.43%
lib/metadataTypes/ContentArea.js  44.79%  100%  0%  44.79%
lib/metadataTypes/DataExtensionField.js  80.23%  65.9%  88.88%  80.23%
lib/metadataTypes/DataExtract.js  90.47%  54.54%  100%  90.47%
lib/metadataTypes/Email.js  61.9%  66.66%  33.33%  61.9%
lib/metadataTypes/FileTransfer.js  88.71%  52.17%  100%  88.71%
lib/metadataTypes/ImportFile.js  82.66%  62.96%  100%  82.66%
lib/metadataTypes/MetadataType.js  78.01%  74%  70.58%  78.01%
lib/metadataTypes/Query.js  92.87%  79.54%  100%  92.87%
lib/metadataTypes/Script.js  95.45%  73.68%  100%  95.45%

@JoernBerkefeld JoernBerkefeld added the c/script COMPONENT label Jan 26, 2024
@JoernBerkefeld JoernBerkefeld mentioned this pull request Jan 29, 2024
Merged
10 tasks
@JoernBerkefeld JoernBerkefeld marked this pull request as ready for review January 29, 2024 15:16
@JoernBerkefeld JoernBerkefeld added the c/asset COMPONENT label Jan 29, 2024
@JoernBerkefeld JoernBerkefeld merged commit ca82130 into develop Jan 29, 2024
8 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/164-enhance-delete-to-support-all-metadata-types-rest branch January 29, 2024 15:18
@JoernBerkefeld JoernBerkefeld linked an issue Jan 29, 2024 that may be closed by this pull request
[FEATURE] enhance delete to support all metadata types (REST) #164
Closed
5 tasks
@github-actions github-actions bot mentioned this pull request Jan 29, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/asset COMPONENT c/dataExtract COMPONENT c/fileTransfer COMPONENT c/importFile COMPONENT c/script COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] enhance delete to support all metadata types (REST)
1 participant
@JoernBerkefeld